lib/feeb/db/sqlite.ex (1)

44-52: bind/2: good API alignment; refine exception logging and add a typespec.

Catching ArgumentError to normalize into {:error, :arguments_wrong_length} is sensible. Two tweaks recommended:

• Log the exception with stacktrace for better debuggability.
• Add a typespec for bind/2 to document the contract.

Apply:

   def bind(stmt, bindings) when is_list(bindings) do
+    @spec bind(stmt(), list()) :: :ok | {:error, :arguments_wrong_length}
     try do
       Driver.bind(stmt, bindings)
     rescue
       e in ArgumentError ->
-        Logger.error(e)
+        Logger.error(Exception.format(:error, e, __STACKTRACE__))
         {:error, :arguments_wrong_length}
     end
   end

Optional: include metadata like the number of args (not their values) to avoid logging PII, e.g., "args_count=#{length(bindings)}".

Also note you kept bind/3 only for the [] case; any remaining 3-arity, non-empty calls will now fail at compile time — which is fine, just ensure none remain (see scan in mix.exs comment).

Would you like me to also add a unit test that verifies we log (captured via @tag :capture_log) and return {:error, :arguments_wrong_length} when passing a wrong number of parameters?

lib/feeb/db/repo.ex (2)

235-241: Switch to SQLite.bind/2 is correct; consider a clearer error for argument-length mismatches.

The with clause now correctly expects :ok from SQLite.bind/2. If bind fails with {:error, :arguments_wrong_length}, it flows to the generic else and logs an opaque error. Consider handling that case explicitly to aid debugging:

     with {:ok, {stmt, stmt_sql}} <- prepare_query(state, query_id, sql),
          true = stmt_sql == sql,
          :ok <- SQLite.bind(stmt, bindings_values),
          {:ok, rows} <- SQLite.all(state.conn, stmt) do
       …
     else
+      {:error, :arguments_wrong_length} = err ->
+        Logger.error("Wrong number of parameters for #{inspect(query_id)} (got #{length(bindings_values)})")
+        {:reply, err, state}
       {:error, _} = err ->
         Logger.error("error: #{inspect(err)}")
         {:reply, err, state}
     end

---

257-266: Unreachable code after raise "Remove or document usage" in prepared_raw path.

This callback raises unconditionally; the code below will never run and can be deleted to avoid confusion. If you intend to keep it for future work, replace raise with a feature flag or Logger.warning/1 plus an explicit error reply.

   def handle_call({:prepared_raw, raw_sql, bindings_values, opts}, _from, state) do
-    raise "Remove or document usage"
-
-    with {:ok, stmt} <- SQLite.prepare(state.conn, raw_sql),
-         :ok <- SQLite.bind(stmt, bindings_values),
-         {:ok, rows} <- SQLite.all(state.conn, stmt) do
-      schema = Keyword.fetch!(opts, :schema)
-      result = format_custom(:all, schema, rows)
-      {:reply, result, state}
-    else
-      {:error, _} = err ->
-        Logger.error("error: #{inspect(err)}")
-        # TODO: Rollback?
-        {:reply, err, state}
-    end
+    {:reply, {:error, :prepared_raw_disabled}, state}
   end

test/db/sqlite_test.exs (2)

27-32: Good negative test; also update the describe title from bind/3 to bind/2.

The assertions for wrong-length args are correct and @tag :capture_log prevents noisy logs. The section header still says "bind/3" though; update for clarity.

Apply:

-describe "bind/3" do
+describe "bind/2" do

Optional: add one case for "too few args" on a 2-parameter statement to cover both directions.

---

102-102: Assert the bind/2 result to surface failures earlier.

Non-assertive call can hide a bind failure; assert it for consistency with other tests.

-      SQLite.bind(stmt, ["Jessie", 1])
+      assert :ok = SQLite.bind(stmt, ["Jessie", 1])

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.